Skip to content

Modularize application (use Java module system) #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

peterzeller
Copy link
Contributor

@peterzeller peterzeller commented Dec 12, 2021

With the modularization, we can use the jlink command (gradle jlink -x test) to build a package including a custom Java Runtime Environment.

This can later be used to automatically download the correct version of Java with the application directly from the VSCode plugin.

Pros:

  • Easy install (just install the plugin)
  • No more problems with wrong Java installations
  • We can update Java without breaking it for users

TODO:

  • Importing the setup tool did not work because of conflicts, so I included the necessary files as decompiled Java files. It's probably better to move these files to a common shared library.
  • Test it.
  • Make code coverage work with Java 17

peq added 6 commits December 13, 2021 00:28
With the modularization, we can use the jpackage command ('gradle
jpackage -x test') to build a package including a whole Java Runtime
Environment.
This can later be used to automatically download the correct version of
Java with the application directly from the VSCode plugin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants